Log in

No account? Create an account
sendfile documentation sucks? - brad's life — LiveJournal [entries|archive|friends|userinfo]
Brad Fitzpatrick

[ website | bradfitz.com ]
[ userinfo | livejournal userinfo ]
[ archive | journal archive ]

sendfile documentation sucks? [Apr. 19th, 2004|09:30 pm]
Brad Fitzpatrick
$ man 2 sendfile (Debian; manpages-dev 1.66-1)

Things to note:

-- it doesn't say offset can be NULL
-- it says "Sendfile does not modify the current file pointer of in_fd, but does for out_fd."

Well, turns out offset can be NULL (Linux 2.6.5, fs/read_write.c:638, sys_sendfile) and the in_fd is moved (*ppos = ... ; Linux 2.6.5, mm/filemap.c:725).

So on one hand I'm disappointed in crappy docs, but at least the source is available. *shrug?*

[User Picture]From: ydna
2004-04-19 10:16 pm (UTC)
How about a patch against the docs to upstream? Not as glorious as a code patch I suppose, but what's there to lose?
(Reply) (Thread)
[User Picture]From: brad
2004-04-19 11:30 pm (UTC)
If I get confirmation from others that I'm seeing things correctly, sure.

Although assuming that makes my program work, I'm not confident enough to document it without a little more playing/reading.
(Reply) (Parent) (Thread)
From: evan
2004-04-20 09:41 am (UTC)
yeah: most free sw docs suck because everyone who figures it out (by reading the source) usually have better things to do than fix the docs.
(Reply) (Parent) (Thread)
[User Picture]From: ydna
2004-04-20 10:06 am (UTC)
Like complaining how much the docs suck. :o)

(Hey, I'm guilty of the same thing too.)
(Reply) (Parent) (Thread)
From: qmrq
2004-04-21 09:00 am (UTC)

off topic :(

Brad! I love Jabber, and am glad you have little bits for it in profile, but why does Jabber status also not show? This should be fairly easy to implement, I've seen it done in PHP.. Also... an option for sending comment reply notifications along with the text would be great! At the moment to get `live' notices I have comment replies sent to my Hotmail account, which is monitored by my message client. A way to also send replies through Jabber would be awesome.. that would be harder to work out though I think. There is module for working with Jabber at cpan.org if any of this sounds worthwhile.

I'm sorry I didn't post this in an appropriate place, but I could not recall the community name where ideas and such go.
(Reply) (Thread)
[User Picture]From: brad
2004-04-21 09:11 am (UTC)

Re: off topic :(

Send us a patch. :)
(Reply) (Parent) (Thread)